fix: Fix sink_ipc_cloud panicking with runtime error
#18091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
philss
force-pushed
the
ps-fix-sink-ipc-cloud-tokio-runtime
branch
2 times, most recently
from
57bd7bc
to
95cd14f
Compare
Fixes pola-rs#13614 When writing to ObjectStore-compatible storage using the IPC format, it seems like the `block_on` calls inside the constructed `CloudWriter` might sometimes get called inside another `block_on` call. Tokio does not like this, resulting in a panic. This PR resolves this issue by using `block_on_potential_spawn` in the necessary places instead. This is a fix that was originally written by @Qqwy in another PR: pola-rs#14262 Co-Authored-By: Qqwy / Marten <qqwy@gmx.com>
philss
force-pushed
the
ps-fix-sink-ipc-cloud-tokio-runtime
branch
from
95cd14f
to
6d59c77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18091 +/- ##
==========================================
- Coverage 80.37% 80.36% -0.01%
==========================================
Files 1496 1496
Lines 197542 197542
Branches 2820 2820
==========================================
- Hits 158771 158758 -13
- Misses 38249 38262 +13
Partials 522 522 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13614
When writing to ObjectStore-compatible storage using the IPC format, it seems like the
block_oncalls inside the constructedCloudWritermight sometimes get called inside anotherblock_oncall. Tokio does not like this, resulting in a panic.This PR resolves this issue by using
block_on_potential_spawnin the necessary places instead.This is a fix that was originally written by @Qqwy in another PR: #14262