Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Py-polars compilation with no features #18129

Merged

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Aug 10, 2024

This fixes the compilation of py-polars with no features.

And should address the compilation failure in #18117.

This fixes the compilation of py-polars with no features.
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (bc65bd0) to head (5138fb2).

Files Patch % Lines
py-polars/src/lazyframe/visitor/expr_nodes.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18129      +/-   ##
==========================================
- Coverage   80.35%   80.33%   -0.02%     
==========================================
  Files        1496     1496              
  Lines      197685   197689       +4     
  Branches     2821     2821              
==========================================
- Hits       158845   158809      -36     
- Misses      38319    38359      +40     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d1e0f63 into pola-rs:main Aug 10, 2024
19 checks passed
@coastalwhite coastalwhite deleted the fix-pypolars-nofeatures-compilation branch August 10, 2024 16:01
@c-peters c-peters added the accepted Ready for implementation label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants