fix: Don't raise when converting from pandas if index contains duplicate names when include_index=False (the default)
#18133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te names when `include_index=False` (the default)
MarcoGorelli
changed the title
include_index=False (the default)include_index=False (the default)
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie and
reswqa
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18133 +/- ##
=======================================
Coverage 80.34% 80.35%
=======================================
Files 1496 1496
Lines 197751 197751
Branches 2822 2822
=======================================
+ Hits 158884 158897 +13
+ Misses 38345 38332 -13
Partials 522 522 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18130