Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parquet with filter=None #18139

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: Parquet with filter=None #18139

merged 1 commit into from
Aug 12, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #18137.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 12, 2024
@ritchie46 ritchie46 merged commit c4c5224 into pola-rs:main Aug 12, 2024
21 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #18139 will improve performances by 29.39%

Comparing coastalwhite:fix-parquet-filter-none (8197ea4) with main (afd93b2)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main coastalwhite:fix-parquet-filter-none Change
⚡ test_groupby_h2oai_q1 2.9 ms 2.2 ms +29.39%

@coastalwhite coastalwhite deleted the fix-parquet-filter-none branch August 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling to_deserializer with filter = None results in a panic
2 participants
@coastalwhite @ritchie46