Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent unwanted supertype cast in 'search_sorted' #18143

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: Prevent unwanted supertype cast in 'search_sorted' #18143

merged 1 commit into from
Aug 12, 2024

Conversation

ritchie46
Copy link
Member

fixes #18096

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.35%. Comparing base (afd93b2) to head (dd1ae54).
Report is 2 commits behind head on main.

Files Patch % Lines
...ars-plan/src/plans/conversion/type_coercion/mod.rs 82.14% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18143   +/-   ##
=======================================
  Coverage   80.34%   80.35%           
=======================================
  Files        1496     1496           
  Lines      197751   197789   +38     
  Branches     2822     2822           
=======================================
+ Hits       158884   158924   +40     
+ Misses      38345    38343    -2     
  Partials      522      522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a3eef6d into main Aug 12, 2024
27 checks passed
@ritchie46 ritchie46 deleted the st branch August 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search_sorted silently allows comparisons between different types
1 participant