Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Ensure default values are included when saving/restoring the current Config state #18151

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Aug 12, 2024

Found a bug with Config object load and save methods; configuration options that had not been explicitly set to a non-default value were not being properly captured or restored.

Fixed this and added suitable test coverage.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Aug 12, 2024
@alexander-beedie alexander-beedie changed the title fix(python): Ensure default values are included when saving the current Config state fix(python): Ensure default values are included when saving/restoring the current Config state Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (8c19d18) to head (e6e4ede).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/polars/config.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18151      +/-   ##
==========================================
- Coverage   80.34%   80.33%   -0.01%     
==========================================
  Files        1496     1496              
  Lines      197809   197814       +5     
  Branches     2822     2824       +2     
==========================================
- Hits       158934   158923      -11     
- Misses      38353    38369      +16     
  Partials      522      522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a478cf3 into pola-rs:main Aug 14, 2024
21 checks passed
@alexander-beedie alexander-beedie deleted the fix-config-save-load-state branch August 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants