Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Cargo.lock to fix build error on Linux #18153

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Aug 13, 2024

mod tests {
    #[test]
    fn test() {
        struct X {}
        impl std::ops::Deref for X {
            type Target = [u8];

            fn deref(&self) -> &Self::Target {
                &[]
            }
        }

        let x = X {};
        let _deref = &*x;
        let _asref = x.as_ref();
    }
}

The above currently fails on Linux due to bstr - updating Cargo.lock removes it from the dependencies

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 13, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review August 13, 2024 09:13
@nameexhaustion nameexhaustion changed the title chore: Update Cargo.lock to fix inconsistent build error MacOS<->Linux chore: Update Cargo.lock to fix build error on Linux Aug 13, 2024
@orlp orlp merged commit 1b5fa4c into pola-rs:main Aug 13, 2024
8 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
@nameexhaustion nameexhaustion deleted the cargo-lock branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants