Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Corrected example result in group_by docs #18169

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

rosstitmarsh
Copy link
Contributor

Fix for issue #18168

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Aug 13, 2024
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rosstitmarsh

personally i'd advocate for removing the doctest skips and just adding an extra sort, but that's for a separate discussion, i don't want to block this pr

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (41318c3) to head (0afd613).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18169      +/-   ##
==========================================
- Coverage   80.35%   80.31%   -0.05%     
==========================================
  Files        1496     1498       +2     
  Lines      197825   198632     +807     
  Branches     2822     2822              
==========================================
+ Hits       158966   159528     +562     
- Misses      38337    38582     +245     
  Partials      522      522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli merged commit 7991a94 into pola-rs:main Aug 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants