Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix unpivot on empty df #18179

Merged
merged 5 commits into from
Aug 14, 2024
Merged

fix: Fix unpivot on empty df #18179

merged 5 commits into from
Aug 14, 2024

Conversation

ritchie46
Copy link
Member

fixes #18170

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 95.51282% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (21f02a6) to head (641c728).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/plans/functions/schema.rs 20.00% 4 Missing ⚠️
crates/polars-plan/src/plans/functions/mod.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18179      +/-   ##
==========================================
- Coverage   80.31%   80.30%   -0.02%     
==========================================
  Files        1498     1500       +2     
  Lines      198654   198669      +15     
  Branches     2831     2833       +2     
==========================================
- Hits       159555   159542      -13     
- Misses      38572    38600      +28     
  Partials      527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8111493 into main Aug 14, 2024
27 checks passed
@ritchie46 ritchie46 deleted the unpivot branch August 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unpivot() on an empty DataFrame creates two empty variable columns
1 participant