Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't load Parquet nested metadata #18183

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #18136.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 14, 2024
Copy link

codspeed-hq bot commented Aug 14, 2024

CodSpeed Performance Report

Merging #18183 will improve performances by 42.42%

Comparing coastalwhite:fix-parquet-nested-metadata (c321dc1) with main (8111493)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main coastalwhite:fix-parquet-nested-metadata Change
test_groupby_h2oai_q5 2.6 ms 1.8 ms +42.42%

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (21f02a6) to head (c321dc1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18183   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files        1498     1500    +2     
  Lines      198654   198719   +65     
  Branches     2831     2833    +2     
=======================================
+ Hits       159555   159609   +54     
- Misses      38572    38583   +11     
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f92f147 into pola-rs:main Aug 14, 2024
21 checks passed
@coastalwhite coastalwhite deleted the fix-parquet-nested-metadata branch August 14, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect statistics are loaded from parquet containing structs
2 participants