Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create literals for datetime/date expressions #18184

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat: Create literals for datetime/date expressions #18184

merged 1 commit into from
Aug 14, 2024

Conversation

ritchie46
Copy link
Member

Much clearer for the optimizer.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Aug 14, 2024
Copy link

codspeed-hq bot commented Aug 14, 2024

CodSpeed Performance Report

Merging #18184 will improve performances by 42.56%

Comparing lit (df1bc35) with main (8111493)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main lit Change
test_groupby_h2oai_q5 2.6 ms 1.8 ms +42.56%

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (8111493) to head (df1bc35).
Report is 33 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/dsl/functions/temporal.rs 86.44% 8 Missing ⚠️
crates/polars-arrow/src/temporal_conversions.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18184      +/-   ##
==========================================
- Coverage   80.32%   80.30%   -0.02%     
==========================================
  Files        1500     1500              
  Lines      198745   198810      +65     
  Branches     2833     2833              
==========================================
+ Hits       159634   159662      +28     
- Misses      38584    38621      +37     
  Partials      527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0276aec into main Aug 14, 2024
21 of 22 checks passed
@ritchie46 ritchie46 deleted the lit branch August 14, 2024 12:57
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants