Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the required version of rust in README.md #18203

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

StepfenShawn
Copy link
Contributor

Run with rust 1.77 stable, Rust Polars 0.42.0:

cargo run -r
   Compiling polars-arrow v0.42.0
error[E0658]: inline-const is experimental
  --> E:\Program-Files\rust\.cargo\registry\src\rsproxy.cn-0dccff568467c15b\polars-arrow-0.42.0\src\array\static_array.rs:70:9
   |
70 |         no_call_const!()
   |         ^^^^^^^^^^^^^^^^
   |
   = note: see issue #76001 <https://github.com/rust-lang/rust/issues/76001> for more information
   = note: this error originates in the macro `no_call_const` (in Nightly builds, run with -Z macro-backtrace for more info)

I found that this macro uses Inline const expressions, which has been stable since version Rust 1.79 stable:

#[macro_export]
macro_rules! no_call_const {
    () => {{
        const { assert!(false, "should not be called") }
        unreachable!()
    }};
}

refer to https://blog.rust-lang.org/2024/06/13/Rust-1.79.0.html

@ritchie46 ritchie46 changed the title Update the required version of rust in README.md chore: Update the required version of rust in README.md Aug 16, 2024
@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 0341d4c into pola-rs:main Aug 16, 2024
2 of 3 checks passed
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants