Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Make show_versions more responsive #18208

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat(python): Make show_versions more responsive #18208

merged 3 commits into from
Aug 15, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 15, 2024

Instead of waiting for all imports to finish before showing any output, now pl.show_versions() will show versions as we compute them.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Aug 15, 2024
stinodego
stinodego reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this is a bit nicer 👍 just one comment on the implementation.

py-polars/polars/meta/versions.py Outdated Show resolved Hide resolved
@stinodego stinodego merged commit df57225 into pola-rs:main Aug 15, 2024
12 of 14 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@orlp orlp

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orlp @stinodego @c-peters