Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Fix test for new deltalake release #18211

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

ion-elgreco
Copy link
Contributor

@ion-elgreco ion-elgreco commented Aug 15, 2024

We need to explicitly provide overwrite mode when setting overwrite_schema = True

@stinodego :)

@ion-elgreco ion-elgreco changed the title fix: set overwrite mode fix(python): set overwrite mode Aug 15, 2024
@stinodego stinodego changed the title fix(python): set overwrite mode test(python): Fix test for new deltalake release\ Aug 15, 2024
@stinodego stinodego changed the title test(python): Fix test for new deltalake release\ test(python): Fix test for new deltalake release Aug 15, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars and removed title needs formatting labels Aug 15, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ion-elgreco Thanks! That fixes one of the tests, there is one more still failing - test_write_delta. It complains that a file already exists, probably because it's not overwriting correctly?

@ion-elgreco
Copy link
Contributor Author

@stinodego ah didn't see that one, one sec

Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to merge if CI is green.

@ion-elgreco
Copy link
Contributor Author

Thanks! Good to merge if CI is green.

Seems more tests are incompatible, will. Compile it locally and run it

@stinodego
Copy link
Member

stinodego commented Aug 15, 2024

Seems more tests are incompatible, will. Compile it locally and run it

There seem to be some differences between Linux / Windows 🤔 first Windows failed and Linux passed, now it's the other way around.

@ion-elgreco
Copy link
Contributor Author

Seems more tests are incompatible, will. Compile it locally and run it

There seem to be some differences between Linux / Windows 🤔 first Windows failed and Linux passed, now it's the other way around.

Ah yes that's because Linux wheels for 0.19 failed, due to some issue with maturin, I am waiting on my PR to be merged in delta-rs so I can re release them

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (4157e92) to head (ddb4b2a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18211      +/-   ##
==========================================
- Coverage   80.30%   80.29%   -0.01%     
==========================================
  Files        1498     1497       -1     
  Lines      198751   198741      -10     
  Branches     2833     2837       +4     
==========================================
- Hits       159598   159579      -19     
- Misses      38626    38635       +9     
  Partials      527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco
Copy link
Contributor Author

@stinodego tests should be fine now, did a local compile with a deltalake v0.19. I'll ping you when I fixed our python wheels

@stinodego stinodego merged commit bd328a0 into pola-rs:main Aug 16, 2024
13 checks passed
@ion-elgreco ion-elgreco deleted the fix/delta_test branch August 16, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants