Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Make json readers ignore BOM character #18240

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

deanm0000
Copy link
Collaborator

Fixes #15301

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (8d43ba1) to head (3dfea6f).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/json/mod.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18240      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.02%     
==========================================
  Files        1501     1501              
  Lines      198925   198935      +10     
  Branches     2837     2837              
==========================================
- Hits       159576   159562      -14     
- Misses      38821    38845      +24     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Aug 16, 2024

CodSpeed Performance Report

Merging #18240 will not alter performance

Comparing deanm0000:json_ignore_bom (3dfea6f) with main (8d43ba1)

Summary

✅ 37 untouched benchmarks

crates/polars-io/src/json/mod.rs Outdated Show resolved Hide resolved
crates/polars-io/src/json/mod.rs Outdated Show resolved Hide resolved
crates/polars-json/src/ndjson/remove_bom.rs Outdated Show resolved Hide resolved
crates/polars-json/src/ndjson/file.rs Outdated Show resolved Hide resolved
@ritchie46
Copy link
Member

Thanks @deanm0000

@ritchie46 ritchie46 merged commit 450d0f1 into pola-rs:main Aug 21, 2024
21 checks passed
@deanm0000 deanm0000 deleted the json_ignore_bom branch August 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_ndjson read_json: Add encoding parameter
2 participants