fix: Consistently round half-way points down in dt.round #18245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
github-actions
bot
added
fix
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
MarcoGorelli
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18245 +/- ##
==========================================
- Coverage 80.30% 80.24% -0.06%
==========================================
Files 1499 1500 +1
Lines 198744 198889 +145
Branches 2837 2837
==========================================
+ Hits 159604 159606 +2
- Misses 38613 38756 +143
Partials 527 527 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Aug 18, 2024
| @@ -5,6 +5,11 @@ use polars_core::prelude::*; | |||
| use polars_utils::cache::FastFixedCache; | |||
|
|
|||
| use crate::prelude::*; | |||
| use crate::truncate::fast_truncate; | |||
|
|
|||
| fn fast_round(t: i64, every: i64) -> i64 { | |||
There was a problem hiding this comment.
can you tag this with inline(always)?
ritchie46
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18239