fix: Fix duplicate column output and panic for include_file_paths
#18255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
changed the title
include_file_pathsinclude_file_paths
github-actions
bot
added
fix
nameexhaustion
commented
Aug 18, 2024
| @@ -461,7 +461,7 @@ pub trait ChunkFilter<T: PolarsDataType> { | |||
| /// Create a new ChunkedArray filled with values at that index. | |||
| pub trait ChunkExpandAtIndex<T: PolarsDataType> { | |||
| /// Create a new ChunkedArray filled with values at that index. | |||
| fn new_from_index(&self, length: usize, index: usize) -> ChunkedArray<T>; | |||
| fn new_from_index(&self, index: usize, length: usize) -> ChunkedArray<T>; | |||
There was a problem hiding this comment.
index and length were flipped on the trait definition
nameexhaustion
commented
Aug 18, 2024
| self | ||
| #[cfg(debug_assertions)] | ||
| { | ||
| return self.with_column(column).unwrap(); |
There was a problem hiding this comment.
drive-by - enable checks here in debug mode to prevent similar mistakes
nameexhaustion
commented
Aug 18, 2024
| @@ -210,20 +209,6 @@ impl ParquetExec { | |||
| )? | |||
| .finish()?; | |||
|
|
|||
| if let Some(col) = &self.file_options.include_file_paths { | |||
There was a problem hiding this comment.
This was duplicate from a very old implementation approach that didn't push include_file_paths into the actual reader.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18255 +/- ##
=======================================
Coverage 80.23% 80.24%
=======================================
Files 1500 1500
Lines 198889 198882 -7
Branches 2837 2837
=======================================
+ Hits 159573 159585 +12
+ Misses 38789 38770 -19
Partials 527 527 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
changed the title
include_file_pathsinclude_file_paths
ritchie46
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18219 (comment)
Also fixes a panic for batched CSV and Parquet (fixes #18257)