Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve decimal_comma error message #18269

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

markxwang
Copy link
Contributor

fixes #18268

@markxwang markxwang changed the title #18268 docs: improve decimal_comma error message docs: improve decimal_comma error message Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (c88da1f) to head (34a35a9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18269   +/-   ##
=======================================
  Coverage   80.21%   80.22%           
=======================================
  Files        1500     1500           
  Lines      198897   198897           
  Branches     2837     2837           
=======================================
+ Hits       159547   159563   +16     
+ Misses      38822    38806   -16     
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markxwang markxwang changed the title docs: improve decimal_comma error message docs: Improve decimal_comma error message Aug 20, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 20, 2024
@ritchie46 ritchie46 changed the title docs: Improve decimal_comma error message feat: Improve decimal_comma error message Aug 20, 2024
@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 9c186af into pola-rs:main Aug 20, 2024
23 of 25 checks passed
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Aug 20, 2024
@markxwang markxwang deleted the fix-decimal-comma-error-message branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve decimal_comma error message
2 participants