Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add output_schema to all PhysNodes #18272

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 19, 2024

This is necessary for lowering expressions, we need to be able to get the schema of arbitrary PhysNodes.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (c88da1f) to head (9a65d73).
Report is 43 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/skeleton.rs 0.00% 8 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/physical_plan/mod.rs 0.00% 6 Missing ⚠️
crates/polars-plan/src/plans/ir/schema.rs 0.00% 1 Missing ⚠️
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18272   +/-   ##
=======================================
  Coverage   80.21%   80.22%           
=======================================
  Files        1500     1501    +1     
  Lines      198897   198908   +11     
  Branches     2837     2837           
=======================================
+ Hits       159547   159572   +25     
+ Misses      38822    38808   -14     
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 732d50b into pola-rs:main Aug 20, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants