Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify coalesce behaviour in join_asof #18273

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #18089

Join asof is like a left-join, so I think the argument (and description) can be simplified too, right? it's either true or false, nothing join-dependent

@MarcoGorelli MarcoGorelli changed the title docs: clarify coalesce behaviour in join_asof docs: Clarify coalesce behaviour in join_asof Aug 19, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (c88da1f) to head (5ee4bb2).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-python/src/lazyframe/general.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18273      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.02%     
==========================================
  Files        1500     1500              
  Lines      198897   198896       -1     
  Branches     2837     2837              
==========================================
- Hits       159547   159516      -31     
- Misses      38822    38852      +30     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review August 19, 2024 18:32
@ritchie46 ritchie46 merged commit 85b492d into pola-rs:main Aug 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.join_asof() - give example of what coalesce argument does
2 participants