Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support pre-signed URLs for cloud scan #18274

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Aug 20, 2024

Fixes #18186
I don't have GCS to test but it should also fix #14908

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (c88da1f) to head (4ec98fc).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/cloud/polars_object_store.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18274      +/-   ##
==========================================
- Coverage   80.21%   80.21%   -0.01%     
==========================================
  Files        1500     1500              
  Lines      198897   198915      +18     
  Branches     2837     2837              
==========================================
+ Hits       159547   159559      +12     
- Misses      38822    38828       +6     
  Partials      528      528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review August 20, 2024 06:33
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hack!

@ritchie46 ritchie46 merged commit 3d8811c into pola-rs:main Aug 20, 2024
22 checks passed
@nameexhaustion nameexhaustion deleted the presigned branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants