docs(python): Fix typos and add see also links to struct name expressions #18282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
henryharbeck
commented
Aug 20, 2024
| @@ -97,7 +97,6 @@ These functions are available from the Polars module root and can be used as exp | |||
| Expr.any | |||
| Expr.approx_n_unique | |||
| Expr.count | |||
| Expr.exclude | |||
There was a problem hiding this comment.
Expr.exclude also exists under the Columns / names category, so this was a duplicate doc entry here.
henryharbeck
commented
Aug 20, 2024
Comment on lines
+684
to
+686
| name.map | ||
| name.prefix | ||
| name.suffix |
There was a problem hiding this comment.
Given these are no longer in the same namespace as alias, this needs to be done for them to link correctly in the docs.
henryharbeck
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18282 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 1500 1501 +1
Lines 198897 198908 +11
Branches 2837 2837
=======================================
+ Hits 159547 159557 +10
- Misses 38822 38823 +1
Partials 528 528 ☔ View full report in Codecov by Sentry. |
alexander-beedie
approved these changes
Aug 20, 2024
|
Good stuff 👌 |
|
Thank you! Appreciate the speedy review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have built the docs locally and verified that all changes render correctly.