Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Deprecate serialize json for LazyFrame #18283

Merged
merged 2 commits into from
Aug 20, 2024
Merged

refactor(python): Deprecate serialize json for LazyFrame #18283

merged 2 commits into from
Aug 20, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Aug 20, 2024

Doesn't need to be human readable. Especially since json cannot support all our state, so this may not round-trip. Also want to remove it, so I can drop the serde proc macro's on our DSL.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Aug 20, 2024
@ritchie46 ritchie46 merged commit 67551b6 into main Aug 20, 2024
13 checks passed
@ritchie46 ritchie46 deleted the json branch August 20, 2024 13:49
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (4f5febe) to head (fa9d3f9).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18283   +/-   ##
=======================================
  Coverage   80.19%   80.20%           
=======================================
  Files        1501     1501           
  Lines      198908   198911    +3     
  Branches     2837     2837           
=======================================
+ Hits       159522   159543   +21     
+ Misses      38858    38840   -18     
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants