Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check groups in group-by filter #18300

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: Check groups in group-by filter #18300

merged 1 commit into from
Aug 21, 2024

Conversation

ritchie46
Copy link
Member

fixes #18295

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (0f0e12b) to head (d2c9fc7).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-expr/src/expressions/mod.rs 0.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/gather.rs 90.00% 1 Missing ⚠️
crates/polars-expr/src/expressions/ternary.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18300   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files        1501     1501           
  Lines      198944   198943    -1     
  Branches     2837     2837           
=======================================
+ Hits       159543   159551    +8     
+ Misses      38873    38864    -9     
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 84d6f80 into main Aug 21, 2024
27 checks passed
@ritchie46 ritchie46 deleted the filter branch August 21, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why do the two results differ with different sort orders before group_by?
1 participant