Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add Graphviz physical plan visualization for new streaming engine #18307

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 21, 2024

This is fairly quick-and-dirty implementation, just set POLARS_VISUALIZE_PHYSICAL_PLAN="tmp.dot" before running your command to get a visualization. Going to be helpful while debugging the new streaming engine.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (276990e) to head (a748c02).
Report is 28 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/physical_plan/mod.rs 0.00% 25 Missing ⚠️
crates/polars-stream/src/skeleton.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18307   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files        1501     1501           
  Lines      198915   198944   +29     
  Branches     2837     2837           
=======================================
+ Hits       159521   159548   +27     
- Misses      38866    38868    +2     
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice! So set the env var with the location to write it to?

@orlp
Copy link
Collaborator Author

orlp commented Aug 22, 2024

Nice! So set the env var with the location to write it to?

Yep :)

@ritchie46 ritchie46 merged commit bb5664a into main Aug 22, 2024
21 checks passed
@ritchie46 ritchie46 deleted the streaming-phys-plan-dbg branch August 22, 2024 08:44
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants