Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parquet several smaller issues #18325

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

coastalwhite
Copy link
Collaborator

This fixes several small parquet problems.

I would recommend reviewing this PR commit by commit.

Fixes #18304.
Fixes #18303.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 23, 2024
@@ -202,6 +202,17 @@ pub fn columns_to_iter_recursive(
)?
.collect_n(filter)?
},
Binary | Utf8 => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support those types. I think we directly use BinviewDecoder here if we can.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will leave this for this PR. But we should be able to remove the code that generates (Large)Utf8, (LargeBinary) in favor of BinaryView.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 63.77953% with 138 lines in your changes missing coverage. Please review.

Project coverage is 80.50%. Comparing base (9833887) to head (e6c2977).
Report is 8 commits behind head on main.

Files Patch % Lines
...rates/polars-parquet/src/arrow/write/dictionary.rs 45.71% 57 Missing ⚠️
...tes/polars-parquet/src/arrow/write/binary/basic.rs 0.00% 24 Missing ⚠️
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 64.81% 19 Missing ⚠️
...parquet/src/arrow/read/deserialize/binary/basic.rs 0.00% 6 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/binview.rs 0.00% 6 Missing ⚠️
...et/src/arrow/read/deserialize/fixed_size_binary.rs 0.00% 5 Missing ⚠️
crates/polars-arrow/src/offset.rs 0.00% 4 Missing ⚠️
...quet/src/arrow/read/deserialize/primitive/basic.rs 20.00% 4 Missing ⚠️
...es/polars-parquet/src/arrow/write/binary/nested.rs 0.00% 4 Missing ⚠️
...lars-parquet/src/arrow/read/deserialize/boolean.rs 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18325      +/-   ##
==========================================
+ Coverage   80.35%   80.50%   +0.14%     
==========================================
  Files        1501     1501              
  Lines      199214   199420     +206     
  Branches     2837     2837              
==========================================
+ Hits       160087   160545     +458     
+ Misses      38599    38349     -250     
+ Partials      528      526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cdc741d into pola-rs:main Aug 23, 2024
26 checks passed
ritchie46 pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants