perf: Fix accidental quadratic parquet metadata #18327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
orlp,
c-peters and
coastalwhite
as code owners
github-actions
bot
added
performance
ritchie46
commented
Aug 23, 2024
| @@ -23,29 +22,3 @@ where | |||
| reader.take(length).read_to_end(&mut chunk).await?; | |||
| Result::Ok(chunk) | |||
| } | |||
|
|
|||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18327 +/- ##
==========================================
+ Coverage 80.43% 80.45% +0.02%
==========================================
Files 1492 1492
Lines 198677 198718 +41
Branches 2841 2841
==========================================
+ Hits 159804 159882 +78
+ Misses 38348 38311 -37
Partials 525 525 ☔ View full report in Codecov by Sentry. |
ritchie46
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18319
Have to follow up for statistics as well.