fix: Use correct column names when there are no value columns in unpivot #18340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartSchuurmans
requested review from
ritchie46,
orlp and
c-peters
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18340 +/- ##
==========================================
- Coverage 79.87% 79.84% -0.03%
==========================================
Files 1496 1496
Lines 200281 200309 +28
Branches 2841 2841
==========================================
- Hits 159966 159945 -21
- Misses 39790 39839 +49
Partials 525 525 ☔ View full report in Codecov by Sentry. |
|
thanks @BartSchuurmans - could you add a unit test please? |
BartSchuurmans
force-pushed
the
unpivot-value-name
branch
from
7f36abb
to
02f9c67
Compare
BartSchuurmans
changed the title
BartSchuurmans
force-pushed
the
unpivot-value-name
branch
from
02f9c67
to
8e60321
Compare
|
@MarcoGorelli Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.