Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Partition metadata for parquet statistic loading #18343

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Aug 24, 2024

fixes #18319

I am convinced we need a metadata supertype so we can amortize this as we need this all over.
We also need the arrow schema to be backed by an IndexSet. Currently we need a linear search to get a dtype.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 78.65169% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (5cfc1f0) to head (dd1615d).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-stream/src/nodes/parquet_source.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18343      +/-   ##
==========================================
- Coverage   79.84%   79.82%   -0.03%     
==========================================
  Files        1496     1496              
  Lines      200313   200333      +20     
  Branches     2841     2841              
==========================================
- Hits       159942   159916      -26     
- Misses      39846    39892      +46     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit dd1fc86 into main Aug 24, 2024
21 checks passed
@ritchie46 ritchie46 deleted the parquet branch August 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading wide parquet is 25x slower with polars than pyarrow
1 participant