feat: Respect input time zone if input is pandas Timestamp #18346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
github-actions
bot
added
enhancement
MarcoGorelli
force-pushed
the
preserve-timestamp-tz
branch
from
43c723e
to
f081439
Compare
MarcoGorelli
commented
Aug 24, 2024
py-polars/polars/datatypes/_parse.py
Outdated
Comment on lines
81
to
82
| elif input is datetime: | ||
| elif isinstance(input, type) and issubclass(input, datetime): # type: ignore[redundant-expr] | ||
| # pd.Timestamp subclasses `datetime.datetime` |
There was a problem hiding this comment.
mypy says the first check is redundant, although removing it makes some tests fail with
TypeError: issubclass() arg 1 must be a class
MarcoGorelli
force-pushed
the
preserve-timestamp-tz
branch
from
f081439
to
1c4219d
Compare
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18346 +/- ##
==========================================
- Coverage 79.84% 79.82% -0.02%
==========================================
Files 1496 1496
Lines 200333 200333
Branches 2841 2841
==========================================
- Hits 159952 159916 -36
- Misses 39856 39892 +36
Partials 525 525 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Aug 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses part of #18127
pd.Timestampsubclassesdatetime.datetime, but the current code checks type too tightly (elif input is datetime)