Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix compressed ndjson row count #18371

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Aug 26, 2024

re-opened, this time with 100% plaintext 😁

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (69a2bef) to head (126bfd9).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18371      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files        1496     1496              
  Lines      200333   200336       +3     
  Branches     2841     2841              
==========================================
- Hits       159957   159948       -9     
- Misses      39851    39863      +12     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #18371 will improve performances by 40.3%

Comparing nameexhaustion:compressed-ndjson-count (126bfd9) with main (aa283e6)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main nameexhaustion:compressed-ndjson-count Change
test_groupby_h2oai_q4 2.6 ms 1.8 ms +40.3%

@nameexhaustion nameexhaustion marked this pull request as ready for review August 26, 2024 09:37
@ritchie46 ritchie46 merged commit 4077dc7 into pola-rs:main Aug 26, 2024
28 checks passed
@nameexhaustion nameexhaustion deleted the compressed-ndjson-count branch August 29, 2024 09:58
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants