Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Fix broken feature gate for ParquetReader #18376

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Aug 26, 2024

Very minor fix - ran into this while working on Polars Cloud.

See line 115 of the affected file - it uses the functionality that is gated behind the json feature in the parquet feature flag.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Aug 26, 2024
@stinodego stinodego marked this pull request as ready for review August 26, 2024 11:02
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (f31eb6a) to head (b803a2b).
Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18376   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files        1496     1496           
  Lines      200338   200338           
  Branches     2841     2841           
=======================================
+ Hits       159917   159922    +5     
+ Misses      39896    39891    -5     
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit f07eea3 into main Aug 26, 2024
24 checks passed
@stinodego stinodego deleted the fix-feature-gate branch August 26, 2024 11:31
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants