Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Various small fixes for the new streaming engine #18384

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 26, 2024

Just bumping that failure count down :)

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 26, 2024
@orlp orlp merged commit b1231e0 into pola-rs:main Aug 26, 2024
19 checks passed
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (19a30ed) to head (4b8662b).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/physical_plan/fmt.rs 0.00% 27 Missing ⚠️
crates/polars-stream/src/physical_plan/mod.rs 0.00% 11 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 7 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_map.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/nodes/parquet_source.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/graph.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/reduce.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/zip.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/multiplexer.rs 0.00% 3 Missing ⚠️
crates/polars-stream/src/nodes/filter.rs 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18384      +/-   ##
==========================================
- Coverage   79.84%   79.82%   -0.03%     
==========================================
  Files        1496     1497       +1     
  Lines      200338   200371      +33     
  Branches     2841     2841              
==========================================
- Hits       159951   159937      -14     
- Misses      39862    39909      +47     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants