Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Recursively evaluate is_elementwise for function expressions #18385

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 26, 2024

This fixes issues that the new streaming engine had, such as this:

>>> df = pl.DataFrame({"x": [1, 2, 3]})
>>> df.select(pl.col.x.max().sin())
shape: (1, 1)
┌─────────┐
│ x       │
│ ---     │
│ f64     │
╞═════════╡
│ 0.14112 │
└─────────┘
>>> df.lazy().select(pl.col.x.max().sin()).collect(new_streaming=True)
shape: (3, 1)
┌──────────┐
│ x        │
│ ---      │
│ f64      │
╞══════════╡
│ 0.841471 │
│ 0.909297 │
│ 0.14112  │
└──────────┘

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (19a30ed) to head (007001c).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 21 Missing ⚠️
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 12 Missing ⚠️
crates/polars-stream/src/physical_plan/mod.rs 0.00% 10 Missing ⚠️
crates/polars-stream/src/skeleton.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18385      +/-   ##
==========================================
- Coverage   79.84%   79.79%   -0.05%     
==========================================
  Files        1496     1497       +1     
  Lines      200338   200391      +53     
  Branches     2841     2841              
==========================================
- Hits       159951   159900      -51     
- Misses      39862    39966     +104     
  Partials      525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 25b159d into pola-rs:main Aug 27, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants