-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support reading empty parquet files #18392
Conversation
…with an empty schema and no data.)
… (These may be in the wrong place).
polars/py-polars/pyproject.toml Line 231 in 6f5851d
You can run all tests from the py-polars directory with
To run the Rust tests you can run |
I don't know if this is still the case but I've previously had feedback that Python tests are preferred over Rust tests due to the impact of building Rust tests on CI times (#13139 (comment)). So possibly only having the Python tests is enough. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18392 +/- ##
==========================================
- Coverage 79.87% 79.80% -0.07%
==========================================
Files 1496 1497 +1
Lines 200281 200428 +147
Branches 2841 2844 +3
==========================================
- Hits 159966 159956 -10
- Misses 39790 39947 +157
Partials 525 525 ☔ View full report in Codecov by Sentry. |
crates/polars-parquet/src/parquet/schema/io_thrift/from_thrift.rs
Outdated
Show resolved
Hide resolved
Some minor nits, nothing stopping it from getting merged and me fixing those immediately afterward. @ritchie46 |
@coastalwhite, it is fine to take the PR from here and apply those nits. |
Thanks everyone for being so helpful to a newbie to this project! Much appreciated, @coastalwhite for the fixup and the prompt review by everyone, you are awesome! |
Fix #13457
Add support for reading empty parquet files.
I'm new to this project so I could use help with the unit tests that I added to verify correct behavior. I'm not sure if they are in the correct place/am having trouble getting
make test
to pick up the new tests.