Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Ensure assert_frame_not_equal and assert_series_not_equal raise on mismatched input types #18402

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Aug 27, 2024

Closes #18401.

Ensures both of the "not_equal" asserts also raise on mismatched input types, as their "equal" counterparts do; while such inputs are indeed technically not equal, that is not what the functions are testing.

Added quite a bit of bonus test coverage for the "not_equal" asserts while I was at it, along with additional validation of the expected assert error messages.

@alexander-beedie alexander-beedie changed the title fix(python): Ensure assert_frame_not_equal and `assert_series_not_e… fix(python): Ensure assert_frame_not_equal and assert_series_not_equal raise on mismatched input types Aug 27, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Aug 27, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, thanks for the improvement 👍

@stinodego stinodego merged commit 6146350 into pola-rs:main Aug 29, 2024
14 checks passed
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (fb77bad) to head (2824444).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18402   +/-   ##
=======================================
  Coverage   79.87%   79.88%           
=======================================
  Files        1495     1495           
  Lines      200210   200216    +6     
  Branches     2867     2867           
=======================================
+ Hits       159922   159941   +19     
+ Misses      39742    39729   -13     
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie deleted the fix-assert-frame-not-equal branch August 29, 2024 10:22
r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert_frame_not_equal does not raise when input types are different
2 participants