docs(python): Fix incorrect comments in group_by_dynamic
#18415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufeimath
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18415 +/- ##
==========================================
- Coverage 79.89% 79.88% -0.02%
==========================================
Files 1495 1495
Lines 200214 200214
Branches 2867 2867
==========================================
- Hits 159966 159941 -25
- Misses 39702 39727 +25
Partials 546 546 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group by window can go back to
2021-12-15 23:00:00depending on the end-point optionclosedas shown by the code examples. Hence removing the misleading comment "... starting at 2021-12-16 00:00:00".