Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Group arguments in conversion in a Context #18418

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

ritchie46
Copy link
Member

This is preparation for a fix where we set CSE in eager if we apply expression expansion. This is required as those expressions look stateful in the API, whilst it actually is syntactic sugar for multiple expressions. CSE will hide the symptoms here and align with expectation (except for random).

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 28, 2024
@ritchie46 ritchie46 merged commit 20ce0f1 into main Aug 28, 2024
20 checks passed
@ritchie46 ritchie46 deleted the convert branch August 28, 2024 09:26
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 21 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (22a97bf) to head (1189967).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-plan/src/plans/conversion/dsl_to_ir.rs 72.22% 10 Missing ⚠️
crates/polars-plan/src/plans/mod.rs 0.00% 6 Missing ⚠️
crates/polars-lazy/src/frame/mod.rs 84.84% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18418      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      200261   200277      +16     
  Branches     2867     2867              
==========================================
+ Hits       160034   160038       +4     
- Misses      39681    39693      +12     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

colin-kerkhof pushed a commit to colin-kerkhof/polars that referenced this pull request Aug 28, 2024
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants