refactor(rust): Fencepost error in debug assertion in splitfields #18423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some slice `v` of length `n`, it is UB to call `get_unchecked` with a range starting at `n+1`. Previously, we asserted that `pos <= n`, which is the requirement for `v.get_unchecked(..pos)`, but not `v.get_unchecked(pos+1..)` which has the tighter requirement `pos < n`.
github-actions
bot
added
internal
|
Noticed while reviewing #18413. |
wence-
changed the title
wence-
changed the title
wence-
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18423 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 1495 1495
Lines 200261 200279 +18
Branches 2867 2867
=======================================
+ Hits 160033 160051 +18
Misses 39682 39682
Partials 546 546 ☔ View full report in Codecov by Sentry. |
ritchie46
changed the title
|
I rebranded it as a refactor. As only a debug assert was wrong, not the actual implementation. |
colin-kerkhof
pushed a commit
to colin-kerkhof/polars
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some slice
vof lengthn, it is UB to callget_uncheckedwith a range starting atn+1. Previously, we asserted thatpos <= n, which is the requirement forv.get_unchecked(..pos), but notv.get_unchecked(pos+1..)which has the tighter requirementpos < n.While here, after #18413, tighten the extent of an unsafe block.