Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable CSE in eager if struct are expanded #18426

Merged
merged 4 commits into from
Aug 28, 2024
Merged

fix: Enable CSE in eager if struct are expanded #18426

merged 4 commits into from
Aug 28, 2024

Conversation

ritchie46
Copy link
Member

This will ensure you get stable output as expected. Fixes #18411

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (20ce0f1) to head (f543d18).
Report is 5 commits behind head on main.

Files Patch % Lines
...ates/polars-plan/src/plans/conversion/dsl_to_ir.rs 90.90% 2 Missing ⚠️
...polars-plan/src/plans/conversion/expr_expansion.rs 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18426      +/-   ##
==========================================
+ Coverage   79.93%   79.94%   +0.01%     
==========================================
  Files        1495     1496       +1     
  Lines      200277   200190      -87     
  Branches     2867     2867              
==========================================
- Hits       160082   160051      -31     
+ Misses      39649    39593      -56     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 10aee35 into main Aug 28, 2024
24 of 25 checks passed
@ritchie46 ritchie46 deleted the cse branch August 28, 2024 13:50
@ritchie46
Copy link
Member Author

CI failure is unrelated.

r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nondeterministic execution of value counts + replace
1 participant