fix: Treat explode as gather
#18431
Merged
fix: Treat explode as gather
#18431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18431 +/- ##
==========================================
- Coverage 79.92% 79.92% -0.01%
==========================================
Files 1495 1495
Lines 200279 200117 -162
Branches 2867 2867
==========================================
- Hits 160081 159949 -132
+ Misses 39652 39622 -30
Partials 546 546 ☔ View full report in Codecov by Sentry. |
ritchie46
commented
Aug 28, 2024
| @@ -167,7 +167,7 @@ def test_list_struct_explode_6905() -> None: | |||
| }, | |||
| schema={"group": pl.List(pl.Struct([pl.Field("params", pl.List(pl.Int32))]))}, | |||
| )["group"].list.explode().to_list() == [ | |||
| {"params": None}, | |||
| None, | |||
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats an
explodeoperation as a special case ofgatherfor non-trivial types. This will ensure we have the similar behavior across nested types and can also be much faster as thegathers are specialized (thinkbinviewtypes).fixes #18421