Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove old streaming flag if we're going into new streaming #18438

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 28, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (37a492e) to head (b97f06c).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/skeleton.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18438      +/-   ##
==========================================
- Coverage   79.92%   79.90%   -0.03%     
==========================================
  Files        1495     1496       +1     
  Lines      200279   200200      -79     
  Branches     2867     2867              
==========================================
- Hits       160081   159977     -104     
- Misses      39652    39677      +25     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1b2c25b into pola-rs:main Aug 28, 2024
22 checks passed
r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants