Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): DataFrame write_database not passing down "engine_options" when using ADBC #18451

Conversation

skellys
Copy link
Contributor

@skellys skellys commented Aug 29, 2024

This is my first contribution to polars! Feedback welcome.

Fixes #18478

It's a simple one line fix that allows things like properly creating temporary tables when using any ADBC driver. The test I added is written for sqlite3, but it also works when using the Postgres ADBC driver.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (b2550a0) to head (e70a148).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18451      +/-   ##
==========================================
+ Coverage   79.86%   79.88%   +0.01%     
==========================================
  Files        1496     1496              
  Lines      200364   200364              
  Branches     2867     2867              
==========================================
+ Hits       160012   160052      +40     
+ Misses      39806    39767      -39     
+ Partials      546      545       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Sep 2, 2024

Nice, thanks for this - and the test is a particularly good one!
Validates the update nicely; congrats on the first commit ✌️😎

@alexander-beedie alexander-beedie merged commit 0b65d88 into pola-rs:main Sep 2, 2024
15 checks passed
@skellys skellys deleted the fix/DataFrame_write_database_adbc_temporary_tables branch September 2, 2024 18:13
@skellys
Copy link
Contributor Author

skellys commented Sep 2, 2024

Nice, thanks for this - and the test is a particularly good one! Validates the update nicely; congrats on the first commit ✌️😎

Thanks Alexander for the kind words! More to come.

@alexander-beedie alexander-beedie changed the title fix(python): DataFrame.write_database() not passing along engine_options when using ADBC fix(python): DataFrame write_database not passing down "engine_options" when using ADBC Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.write_database() not passing along engine_options when using ADBC
2 participants