Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Add missing chunk align in pipe sink #18457

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 29, 2024

Fixes a hung test test_streaming_group_by_struct_key for me.

@orlp orlp changed the title fix(rust): add missing chunk align in pipe sink fix(rust): Add missing chunk align in pipe sink Aug 29, 2024
@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars and removed title needs formatting labels Aug 29, 2024
@ritchie46 ritchie46 merged commit 915f164 into pola-rs:main Aug 29, 2024
22 of 24 checks passed
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (b2550a0) to head (affc490).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-pipe/src/executors/sinks/io.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18457      +/-   ##
==========================================
- Coverage   79.86%   79.84%   -0.02%     
==========================================
  Files        1496     1497       +1     
  Lines      200364   201828    +1464     
  Branches     2867     2867              
==========================================
+ Hits       160012   161158    +1146     
- Misses      39806    40124     +318     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants