Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Ensure physical arguments to np ufuncs are rechunked #18471

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Aug 30, 2024

When using POLARS_AUTO_NEW_STREAMING .to_physical() can cause the output to be chunked.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (8b65fe3) to head (1ccde17).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/series/series.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18471      +/-   ##
==========================================
+ Coverage   79.84%   79.86%   +0.02%     
==========================================
  Files        1498     1498              
  Lines      201933   201936       +3     
  Branches     2867     2868       +1     
==========================================
+ Hits       161228   161275      +47     
+ Misses      40159    40114      -45     
- Partials      546      547       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 82628c2 into main Aug 30, 2024
16 checks passed
@ritchie46 ritchie46 deleted the ufunc-rechunk branch August 30, 2024 11:00
@c-peters c-peters added the accepted Ready for implementation label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants