Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change naming to new benchmark setup #18473

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

r-brink
Copy link
Contributor

@r-brink r-brink commented Aug 30, 2024

New PR to make changes to the main repository to align with new benchmark setup.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 30, 2024
Copy link

codspeed-hq bot commented Aug 30, 2024

CodSpeed Performance Report

Merging #18473 will not alter performance

Comparing r-brink:pdsh-benchmark (785d310) with main (8b65fe3)

Summary

✅ 15 untouched benchmarks

🆕 22 new benchmarks
⁉️ 22 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main r-brink:pdsh-benchmark Change
🆕 test_pdsh_q1 N/A 17.2 ms N/A
🆕 test_pdsh_q10 N/A 6.2 ms N/A
🆕 test_pdsh_q11 N/A 4 ms N/A
🆕 test_pdsh_q12 N/A 6 ms N/A
🆕 test_pdsh_q13 N/A 9.6 ms N/A
🆕 test_pdsh_q14 N/A 2.1 ms N/A
🆕 test_pdsh_q15 N/A 2.5 ms N/A
🆕 test_pdsh_q16 N/A 7.6 ms N/A
🆕 test_pdsh_q17 N/A 7 ms N/A
🆕 test_pdsh_q18 N/A 11.9 ms N/A
🆕 test_pdsh_q19 N/A 7.4 ms N/A
🆕 test_pdsh_q2 N/A 3.7 ms N/A
🆕 test_pdsh_q20 N/A 6.1 ms N/A
🆕 test_pdsh_q21 N/A 213.1 ms N/A
🆕 test_pdsh_q22 N/A 6.4 ms N/A
🆕 test_pdsh_q3 N/A 5.4 ms N/A
🆕 test_pdsh_q4 N/A 4.7 ms N/A
🆕 test_pdsh_q5 N/A 4.7 ms N/A
🆕 test_pdsh_q6 N/A 1.8 ms N/A
🆕 test_pdsh_q7 N/A 9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (82628c2) to head (785d310).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18473      +/-   ##
==========================================
- Coverage   79.86%   79.85%   -0.02%     
==========================================
  Files        1498     1498              
  Lines      201936   201936              
  Branches     2868     2868              
==========================================
- Hits       161276   161251      -25     
- Misses      40113    40138      +25     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 37e9ccd into pola-rs:main Aug 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants