Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various schema corrections #18474

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: Various schema corrections #18474

merged 1 commit into from
Aug 30, 2024

Conversation

ritchie46
Copy link
Member

  • fix: Window expressions now show proper schema
  • fix: Raise when namespace is called in invalid dtypes
  • chore: Split up code for maintainability
  • perf: Ensure we don't hit the function resolving every time
  • perf: Delay alloction

fixes #18468

- fix: Window expressions now show proper schema
- fix: Raise when namespace is called in invalid dtypes
- chore: Split up code for maintainability
- perf: Ensure we don't hit the function resolving every time
- perf: Delay alloction
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 30, 2024
@@ -296,7 +296,13 @@ pub(super) fn process_binary(
st = String
}

// only cast if the type is not already the super type.
// TODO! raise here?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try this in a follow up.

@ritchie46 ritchie46 merged commit a5dc30d into main Aug 30, 2024
26 checks passed
@ritchie46 ritchie46 deleted the schema branch August 30, 2024 12:50
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 89.38547% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (8b65fe3) to head (4c337ce).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s-plan/src/plans/conversion/type_coercion/is_in.rs 84.84% 10 Missing ⚠️
...an/src/plans/conversion/type_coercion/functions.rs 88.88% 5 Missing ⚠️
...tes/polars-plan/src/plans/conversion/expr_to_ir.rs 75.00% 2 Missing ⚠️
...ates/polars-plan/src/plans/conversion/functions.rs 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18474      +/-   ##
==========================================
+ Coverage   79.84%   79.87%   +0.03%     
==========================================
  Files        1498     1501       +3     
  Lines      201933   202032      +99     
  Branches     2867     2868       +1     
==========================================
+ Hits       161228   161375     +147     
+ Misses      40159    40110      -49     
- Partials      546      547       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.str methods silenty cast input
1 participant