fix: Properly raise on invalid selector expressions #18511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
ritchie46
reviewed
Sep 2, 2024
| ) | ||
|
|
||
| with pytest.raises(InvalidOperationError, match="invalid selector expression"): | ||
| lf.unique(subset=[["bar", "ham"]]) |
There was a problem hiding this comment.
What kind of expression does this lead to in crates/polars-plan/src/plans/conversion/expr_expansion.rs:L928?
There was a problem hiding this comment.
The input is parsed as a list with one element: a String Series with two elements ("bar", "ham"). Which is "correct", just not valid input for selector expansion.
So it becomes a Literal, not a Column.
stinodego
force-pushed
the
expand-selector
branch
from
8b300c1
to
ef11baf
Compare
stinodego
force-pushed
the
expand-selector
branch
from
ef11baf
to
6f8d752
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18511 +/- ##
==========================================
+ Coverage 79.87% 79.89% +0.01%
==========================================
Files 1501 1501
Lines 202032 202029 -3
Branches 2868 2868
==========================================
+ Hits 161370 161405 +35
+ Misses 40115 40077 -38
Partials 547 547 ☔ View full report in Codecov by Sentry. |
stinodego
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18499