fix(python): Address incorrect align_frames
result when the alignment column contains NULL values
#18521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally
align_frames
uses joins, but the default behaviour for joins is for NULL values not to match, which can result in extraneous/incorrect rows being generated during frame alignment if the alignment column(s) contain such values.This PR fixes that oversight 👌
Example
Before
Additional row gets (incorrectly) introduced:
After
Correct number of appropriately aligned rows: