Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Ensure result name of pow matches schema in grouped context #18533

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented Sep 3, 2024

We must transfer the name from the base column to the result so that the rule that the left operand produces the result name is obeyed.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Sep 3, 2024
@ritchie46
Copy link
Member

If CI is green. :)

@wence-
Copy link
Collaborator Author

wence- commented Sep 3, 2024

If CI is green. :)

Ah oops, I had this based on py-polars 1.6.0 (before the smallstr changes) and then just ported it forward and didn't check if things still built.

@wence-
Copy link
Collaborator Author

wence- commented Sep 3, 2024

But note that this does induce a behaviour change (and I had to update a test that was checking for the old naming behaviour), so it is "breaking".

@wence-
Copy link
Collaborator Author

wence- commented Sep 3, 2024

Looks like the recent 0.4.3 uv release changed some dependency solve resolution and the 3.12 mypy failure is that it backtracks to try and install llvmlite 0.36, which is not supported on 3.12.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (af8738c) to head (ce7a915).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18533   +/-   ##
=======================================
  Coverage   79.82%   79.83%           
=======================================
  Files        1502     1502           
  Lines      201933   201936    +3     
  Branches     2868     2868           
=======================================
+ Hits       161201   161211   +10     
+ Misses      40186    40179    -7     
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We must transfer the name from the base column to the result so that
the rule that the left operand produces the result name is obeyed.

- Closes pola-rs#18524
@ritchie46
Copy link
Member

If we didn't respect LHS, the test was flawed.

@ritchie46 ritchie46 merged commit e09cd0b into pola-rs:main Sep 6, 2024
26 checks passed
@wence- wence- deleted the wence/fix/18524 branch September 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema for groupby-agg of literal raised to some power does not match collect result.
2 participants